fix NPE on line pointerSettingsCategory #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are two states in language and input settings. On the one hand the normal which is accessable from the settings and the one if the user press the button for settings in the IME switcher popup. This removes all default views and add dynamic ones. Due that Stylus option do not belong to the dynamic view it will end up in a crash (NPE see removeAllViews() before) so check which status settings were called and do the work or just skip it Change-Id: Ic7f051d36bc88c3f23de5262e8413c79699afa1b
Change-Id: Ib0d797b3e7f2e4f831f52832776b64c0973880b3
- manage apps; tab selector and ram usage - battery data usage bar - app widget toggle Change-Id: I804b4b47563545d7ab124f4cc4800ef4034bf754
PS2: Forgot to set image name. Change-Id: Ib20d4c7231f147674ed3afd4c438bd83aedbac1d
PS2: Rebase Change-Id: I4bee793580fe32b022cf7cbfc7ca5195d2c9a434
…b022cf7cbfc7ca5195d2c9a434 translated to Russian Change-Id: If6df74aa315f9374b9177ab23508e3b9117c7ced
r-matlock
pushed a commit
to Candy6/packages_apps_Settings
that referenced
this pull request
Jan 1, 2016
… fragment.
When PrivacyGuard is opened, the parent fragment would inflate the layout
which contained a nested fragment. This is bad behavior. Since we couldn't
keep track of the fragments lifecycle, the fragment we instantiated during
inflation would cause an inflate exception if and when we toggled the search
view within the current context.
Mitigate the crash by programmatically replacing the fragment after instantiating it once.
AndroidRuntime
E FATAL EXCEPTION: main
E Process: com.android.settings, PID: 12372
E android.view.InflateException: Binary XML file line SlimRoms#21: Error inflating class fragment
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:763)
E at android.view.LayoutInflater.rInflate(LayoutInflater.java:806)
E at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
...
E Caused by: java.lang.IllegalArgumentException: Binary XML file line SlimRoms#21: Duplicate id 0x7f1001a2, tag nul
l, or parent id 0xffffffff with another fragment for com.android.settings.privacyguard.PrivacyGuardPrefs
E at android.app.FragmentManagerImpl.onCreateView(FragmentManager.java:2120)
E at android.view.LayoutInflater$FactoryMerger.onCreateView(LayoutInflater.java:177)
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:733)
E ... 25 more
Change-Id: I6820ad7d35814f150eedf91140e21c0b8e23322b
PRJosh
pushed a commit
to PRJosh/packages_apps_Settings
that referenced
this pull request
Jan 28, 2016
… fragment.
When PrivacyGuard is opened, the parent fragment would inflate the layout
which contained a nested fragment. This is bad behavior. Since we couldn't
keep track of the fragments lifecycle, the fragment we instantiated during
inflation would cause an inflate exception if and when we toggled the search
view within the current context.
Mitigate the crash by programmatically replacing the fragment after instantiating it once.
AndroidRuntime
E FATAL EXCEPTION: main
E Process: com.android.settings, PID: 12372
E android.view.InflateException: Binary XML file line SlimRoms#21: Error inflating class fragment
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:763)
E at android.view.LayoutInflater.rInflate(LayoutInflater.java:806)
E at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
...
E Caused by: java.lang.IllegalArgumentException: Binary XML file line SlimRoms#21: Duplicate id 0x7f1001a2, tag nul
l, or parent id 0xffffffff with another fragment for com.android.settings.privacyguard.PrivacyGuardPrefs
E at android.app.FragmentManagerImpl.onCreateView(FragmentManager.java:2120)
E at android.view.LayoutInflater$FactoryMerger.onCreateView(LayoutInflater.java:177)
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:733)
E ... 25 more
Change-Id: I6820ad7d35814f150eedf91140e21c0b8e23322b
PRJosh
pushed a commit
to PRJosh/packages_apps_Settings
that referenced
this pull request
Feb 7, 2016
… fragment.
When PrivacyGuard is opened, the parent fragment would inflate the layout
which contained a nested fragment. This is bad behavior. Since we couldn't
keep track of the fragments lifecycle, the fragment we instantiated during
inflation would cause an inflate exception if and when we toggled the search
view within the current context.
Mitigate the crash by programmatically replacing the fragment after instantiating it once.
AndroidRuntime
E FATAL EXCEPTION: main
E Process: com.android.settings, PID: 12372
E android.view.InflateException: Binary XML file line SlimRoms#21: Error inflating class fragment
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:763)
E at android.view.LayoutInflater.rInflate(LayoutInflater.java:806)
E at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
...
E Caused by: java.lang.IllegalArgumentException: Binary XML file line SlimRoms#21: Duplicate id 0x7f1001a2, tag nul
l, or parent id 0xffffffff with another fragment for com.android.settings.privacyguard.PrivacyGuardPrefs
E at android.app.FragmentManagerImpl.onCreateView(FragmentManager.java:2120)
E at android.view.LayoutInflater$FactoryMerger.onCreateView(LayoutInflater.java:177)
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:733)
E ... 25 more
Change-Id: I6820ad7d35814f150eedf91140e21c0b8e23322b
SlimAdmin
pushed a commit
that referenced
this pull request
Feb 25, 2016
… fragment.
When PrivacyGuard is opened, the parent fragment would inflate the layout
which contained a nested fragment. This is bad behavior. Since we couldn't
keep track of the fragments lifecycle, the fragment we instantiated during
inflation would cause an inflate exception if and when we toggled the search
view within the current context.
Mitigate the crash by programmatically replacing the fragment after instantiating it once.
AndroidRuntime
E FATAL EXCEPTION: main
E Process: com.android.settings, PID: 12372
E android.view.InflateException: Binary XML file line #21: Error inflating class fragment
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:763)
E at android.view.LayoutInflater.rInflate(LayoutInflater.java:806)
E at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
...
E Caused by: java.lang.IllegalArgumentException: Binary XML file line #21: Duplicate id 0x7f1001a2, tag nul
l, or parent id 0xffffffff with another fragment for com.android.settings.privacyguard.PrivacyGuardPrefs
E at android.app.FragmentManagerImpl.onCreateView(FragmentManager.java:2120)
E at android.view.LayoutInflater$FactoryMerger.onCreateView(LayoutInflater.java:177)
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:733)
E ... 25 more
Change-Id: I6820ad7d35814f150eedf91140e21c0b8e23322b
IronSharpensIron2717
pushed a commit
to rc420head-M/packages_apps_Settings-1
that referenced
this pull request
Mar 7, 2016
… fragment.
When PrivacyGuard is opened, the parent fragment would inflate the layout
which contained a nested fragment. This is bad behavior. Since we couldn't
keep track of the fragments lifecycle, the fragment we instantiated during
inflation would cause an inflate exception if and when we toggled the search
view within the current context.
Mitigate the crash by programmatically replacing the fragment after instantiating it once.
AndroidRuntime
E FATAL EXCEPTION: main
E Process: com.android.settings, PID: 12372
E android.view.InflateException: Binary XML file line SlimRoms#21: Error inflating class fragment
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:763)
E at android.view.LayoutInflater.rInflate(LayoutInflater.java:806)
E at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
...
E Caused by: java.lang.IllegalArgumentException: Binary XML file line SlimRoms#21: Duplicate id 0x7f1001a2, tag nul
l, or parent id 0xffffffff with another fragment for com.android.settings.privacyguard.PrivacyGuardPrefs
E at android.app.FragmentManagerImpl.onCreateView(FragmentManager.java:2120)
E at android.view.LayoutInflater$FactoryMerger.onCreateView(LayoutInflater.java:177)
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:733)
E ... 25 more
Change-Id: I6820ad7d35814f150eedf91140e21c0b8e23322b
IronSharpensIron2717
pushed a commit
to rc420head-M/packages_apps_Settings-1
that referenced
this pull request
Apr 28, 2016
… fragment.
When PrivacyGuard is opened, the parent fragment would inflate the layout
which contained a nested fragment. This is bad behavior. Since we couldn't
keep track of the fragments lifecycle, the fragment we instantiated during
inflation would cause an inflate exception if and when we toggled the search
view within the current context.
Mitigate the crash by programmatically replacing the fragment after instantiating it once.
AndroidRuntime
E FATAL EXCEPTION: main
E Process: com.android.settings, PID: 12372
E android.view.InflateException: Binary XML file line SlimRoms#21: Error inflating class fragment
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:763)
E at android.view.LayoutInflater.rInflate(LayoutInflater.java:806)
E at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
...
E Caused by: java.lang.IllegalArgumentException: Binary XML file line SlimRoms#21: Duplicate id 0x7f1001a2, tag nul
l, or parent id 0xffffffff with another fragment for com.android.settings.privacyguard.PrivacyGuardPrefs
E at android.app.FragmentManagerImpl.onCreateView(FragmentManager.java:2120)
E at android.view.LayoutInflater$FactoryMerger.onCreateView(LayoutInflater.java:177)
E at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:733)
E ... 25 more
Change-Id: I6820ad7d35814f150eedf91140e21c0b8e23322b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the keyboard is open and the user open the notification bar, click on the setings button to edit the keyboard configurations, this can lead to a crash of fragment stack manager due to a NPE on this line